Skip to content

AMDGPU: Handle f32 minimum3/maximum3 pattern for gfx950 #117737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Nov 26, 2024

No description provided.

This was referenced Nov 26, 2024
Copy link
Contributor

@shiltian shiltian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder why it is called v_maximum3.

@arsenm
Copy link
Contributor Author

arsenm commented Nov 26, 2024

Because that's what it is?

@shiltian
Copy link
Contributor

three operands, alright...

Copy link
Contributor Author

arsenm commented Nov 26, 2024

Merge activity

  • Nov 26, 2:41 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 26, 2:45 PM EST: Graphite rebased this pull request as part of a merge.
  • Nov 26, 2:47 PM EST: A user merged this pull request with Graphite.

@arsenm arsenm force-pushed the users/arsenm/gfx950/legalize-fminimum-fmaximum-f32 branch from 593f540 to 3a72829 Compare November 26, 2024 19:42
Base automatically changed from users/arsenm/gfx950/legalize-fminimum-fmaximum-f32 to main November 26, 2024 19:44
@arsenm arsenm force-pushed the users/arsenm/gfx950/fminimum3-fmaximum3-pattern branch from e109d7d to d4aa2f6 Compare November 26, 2024 19:44
@arsenm arsenm merged commit f5e92eb into main Nov 26, 2024
5 of 7 checks passed
@arsenm arsenm deleted the users/arsenm/gfx950/fminimum3-fmaximum3-pattern branch November 26, 2024 19:47
This was referenced Nov 26, 2024
searlmc1 pushed a commit to ROCm/llvm-project that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants